[PATCH STABLE] push: fix "No changes found" when pushing a phase change (issue4232)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Jan 21 13:58:16 CST 2016



On 01/21/2016 10:21 AM, Matt Mackall wrote:
> On Thu, 2016-01-21 at 10:05 -0800, Laurent Charignon wrote:
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon at fb.com>
>> # Date 1453398185 28800
>> #      Thu Jan 21 09:43:05 2016 -0800
>> # Branch stable
>> # Node ID 77a884362c9f15e6a96a5eebf484ee9a2e085fe4
>> # Parent  f62dea3f36975b3daac82e9dcd0ec964cf30c2a7
>> push: fix "No changes found" when pushing a phase change (issue4232)
>>
>> Before this patch when pushing a change that was only affecting phases, we
>> were
>> printing "no changes found" which was inaccurate. This patch adds a new
>> warning
>> when only phases change but no changesets are exchanges: "no new changesets,
>> only pushing phase changes".
>
> What about pull?
>
> I think the message should be "adjusting phases" (full stop). On push, sometimes
> we simply local draft changes public (so nothing is actually pushed).
>
> (We're also eerily silent for 20 seconds while synchronizing obsmarkers.)

There is output about obsmarker echange somewhere behind an experimental 
flag (because I've some), we should probably apply minimal polish and 
push this out of the wood.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list