[PATCH stable treemanifest] changegroup: fix treemanifest exchange code (issue5061)

Martin von Zweigbergk martinvonz at google.com
Wed Jan 27 16:01:16 CST 2016


On Wed, Jan 27, 2016 at 1:49 PM, Augie Fackler <raf at durin42.com> wrote:
>
> On Jan 27, 2016, at 12:35, Martin von Zweigbergk <martinvonz at google.com>
> wrote:
>
>
>
> On Wed, Jan 27, 2016 at 7:25 AM Augie Fackler <raf at durin42.com> wrote:
>>
>> +Pushing to an empty repo makes that a treemanifest repo
>
>
> This seems like it's taken from the test case I recently added, but it
> doesn't seem accurate for your test. What is really the point of this test
> case? I think it's pretty much the same thing as the test case further down
> using "deepclone", but it just happens to hit some other conditions in the
> lookup function. Also, you could probably switch to "hg clone --pull"
> instead if you prefer. Either way, can I ask for at least a new description?
> Either as a resend or just a text for me to paste.
>
>
> Maybe make this "Pushing to an empty repo works."? I'm not really sure how
> much more detail I can work into it, since that's really all it's doing.

Sure, that's at least not incorrect :-) Pushed to the clowncopter, thanks.


More information about the Mercurial-devel mailing list