[PATCH STABLE v2] debugrevlog: improve handling of empty manifests/changelogs

Yuya Nishihara yuya at tcha.org
Sun Jan 31 02:13:38 CST 2016


On Fri, 29 Jan 2016 12:04:53 -0600, timeless wrote:
> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1453754438 0
> #      Mon Jan 25 20:40:38 2016 +0000
> # Branch stable
> # Node ID 8811fe5c3ab8808191f1eddbb2467718285f7b14
> # Parent  7cb7264cfd52d2672644db4bc16a0bd50aa093ca
> debugrevlog: improve handling of empty manifests/changelogs
> 
> issue5062

Our style is "... (issue5062)", and this patch does not fix the particular
case of issue5062. Can you split patches? This seems to include several
unrelated fixes:

 a) empty revlog
 b) empty entry in revlog

> --- a/mercurial/cmdutil.py
> +++ b/mercurial/cmdutil.py
> @@ -507,8 +507,8 @@
>              filelog = repo.file(file_)
>              if len(filelog):
>                  r = filelog
> -    if not r:
> -        if not file_:
> +    if r is None:
> +        if not any([cl, dir, mf, file_]):
>              raise error.CommandError(cmd, _('invalid arguments'))

--dir isn't a stand-alone option. It requires a FILE argument.

> +  $ hg pull "$TESTDIR/bundles/issue5062.hg" -r 0
> +  pulling from /home/timeless/hg/crew/tests/bundles/issue5062.hg
                        ^^^^^^^^

You can use "hg unbundle" instead.


More information about the Mercurial-devel mailing list