[PATCH] py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import

Yuya Nishihara yuya at tcha.org
Mon Jul 4 09:35:52 EDT 2016


On Sun, 03 Jul 2016 23:05:33 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1467567318 -19800
> #      Sun Jul 03 23:05:18 2016 +0530
> # Node ID 59744695fedf789adab649c85573c553ad750057
> # Parent  59058549a611342f16e6d7e4a99b9e6ea40fa322
> py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import

> --- a/mercurial/hgweb/server.py	Fri Jul 01 13:54:35 2016 +0800
> +++ b/mercurial/hgweb/server.py	Sun Jul 03 23:05:18 2016 +0530
> @@ -8,7 +8,6 @@
>  
>  from __future__ import absolute_import
>  
> -import BaseHTTPServer
>  import errno
>  import os
>  import socket
> @@ -22,6 +21,7 @@
>      util,
>  )
>  
> +http_server = util.httpserver

How about "httpservermod" ?

http_server doesn't follow our style, and it's confusing we have http_server
module and httpserver variable.


More information about the Mercurial-devel mailing list