[PATCH 1 of 3] py3: conditionalize httplib import

Martijn Pieters mj at zopatista.com
Mon Jul 4 15:13:21 EDT 2016

On 4 July 2016 at 18:14, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>> Is there any chance we could switch to using flake8 here instead?
>> flake8 *uses* pyflakes but adds `# noqa: code, code` support to ignore
>> specific linting errors on specific lines. See
>> http://flake8.pycqa.org/en/latest/user/ignoring-errors.html.
>> Flake8 is also vastly more flexible and our check-code.py could
>> possibly be converted into a plugin for flake8.
> Keep in mind that flake8 wraps multiple linting packages. If we go with
> flake8, we may need to customize it to only run the linting packages we care
> about (possibly just pyflakes).

Absolutely. I was thinking about using flake8 with only the same
checks as are done now, but with the added flexibility of flake8's

I've filed a feature request for flake8 to add even more flexibility:
switching off specific tests per file rather than per line or per
project. See https://gitlab.com/pycqa/flake8/issues/156

Martijn Pieters

More information about the Mercurial-devel mailing list