[PATCH] error: mark HintException as a private base class

Matt Mackall mpm at selenic.com
Fri Jul 8 17:33:19 EDT 2016


On Sat, 2016-07-09 at 00:50 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1451137556 -32400
> #      Sat Dec 26 22:45:56 2015 +0900
> # Node ID 1adb7c14f88c38e8570d5198141f493547f9acb6
> # Parent  b4d117cee636be8a566f56e84d4b351a736a1299
> error: mark HintException as a private base class
> 
> HintException is unrelated to the hierarchy of errors. It is an implementation
> detail whether a class inherits from HintException or not, a sort of "private
> inheritance" in C++.

Ok.. but do we want to block/discourage external extensions from using this
class to make their own exception types? We could restructure it as a mix-in?

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list