[PATCH 1 of 3 V3] journal: add dirstate tracking

Martijn Pieters mj at zopatista.com
Mon Jul 11 09:04:36 EDT 2016


On 8 July 2016 at 16:03, Yuya Nishihara <yuya at tcha.org> wrote:
> The code looks good to me, but can you update the commit message to mention
> why jlock() is introduced? It will help future readers who won't remember the
> discussion in the previous thread.

Done for V4.

>>          fm.condwrite(ui.verbose, 'oldhashes', '%s -> ', oldhashesstr)
>>          fm.write('newhashes', '%s', newhashesstr)
>>          fm.condwrite(ui.verbose, 'user', ' %s', entry.user.ljust(8))
>> +        fm.condwrite(opts.get('all'), 'name', '  %s', entry.name.ljust(8))
>
> It isn't a problem of this patch, but these ljust()s should be replaced by
> '%-8s' so that JSON outputs include no padding.

Good catch, V4 will include a JSON test and no ljust.

-- 
Martijn Pieters


More information about the Mercurial-devel mailing list