[PATCH 2 of 2 V3] error: make hintable exceptions reject unknown keyword arguments (API)

Yuya Nishihara yuya at tcha.org
Tue Jul 12 09:11:45 EDT 2016

On Tue, 12 Jul 2016 09:39:25 +0000, Kostia Balytskyi wrote:
> These 2 patches look good to me. Once they are accepted I will introduce
> MercurialException and replace Exception -> MercurialException here. My goal
> is not related to dispatch.runcommand(), but more to unshelve’s
> shelvedstate.load exception-catching, but I think it’s generally a good
> thing to do.

I don't get the point why you prefer catching everything except
MercurialException over catching exceptions that can be raised by
int() and nodemod.bin(). IMHO, it's bad practice to suppress unknown

More information about the Mercurial-devel mailing list