[PATCH 4 of 4 V6] hgweb: add links to diff and changeset views from annotate view table

[Denis Laxalde]

(Following-up on this discussion after submission of a new series.)

Gregory Szorc a écrit :
> Anyway, here are my comments on the last 2 patches in this series:
>
> * Now that we only render the blame info link once per block, you have
> to move your mouse or potentially scroll to the first line of the block
> get the hover info box. I prefer searchfox's interface where hovering
> anywhere in that blame block shows the hover box because it is easier to
> use. GitHub and BB are also more usable here in that all data is
> pre-rendered in each block so no extra work to find element to hover over.

I've implemented this idea. Now the hover-box shows up whenever one
hovers the first column and the box contains the same link as the head
of the "same-revision-block". It's kind of a hidden feature at this
point, maybe it could be made clearer that there's information on this
column even if there's no text in the cell...

> * I *really* like having the summary line of the commit message
> accessible (searchfox and GitHub do this).
>
> * Ditto for the full author name (if we moved author name to the hover
> box we could arguably remove it from the column and do away with our
> variable width badness - but this is arguably for a follow-up).

So I included the full author information in the hover-box and removed
it from the link in the first column (which thus only consists of the
"rev").

> * I feel like we need better styling on the hover box. Something like
> the changeset info from the top of the annotate page would be great.
> (Basically what mpm said.)

Done.

> * I wish there were more padding between the text in the left column and
> the hover box. There are only a few pixels currently and it is really
> cramped. Searchfox gets this right.

Done.

> * I think the link to the parent annotation should go to the
> currently-hovered line. You can also make the argument for having 2
> links: top of file and current line. I think current line is more
> important because annotate is almost always used to see how specific
> parts of the file evolved over time and we want the lines/block under
> examination to be front and center when changing revisions. Searchfox's
> "show latest version without this line" gets this right.

But, unless I'm mistaken, the line information that we have on the
"annotated" revision may not be relevant on its parent so it seems to me
that this would confuse navigation in many cases.

> * Having looked at Searchfox, I'm questioning whether any text content
> in the leftmost column are warranted. Author could be moved to hover
> (see bullet point above). And integer revisions aren't particularly
> useful (I thought we were supposed to avoid integer revisions in hgweb
> since they aren't consistent). If we put hashes there, we lose the value
> of knowing N+1 is newer than N. So since nothing really useful can go
> there, why have anything at all? Following the same logic, we could
> potentially replace the existing text with links to important revisions
> for this line and use the hover to show changeset info. Something to
> think about.

I agree that we could reconsider the information in the first column. If
we go and drop the revision number, we'd still need a visual hint to
clearly identify identical revisions on the left column. Using colors
like searchfox/github looks like a good idea.

-- 
Denis Laxalde
Logilab         http://www.logilab.fr