[PATCH] compat: provide a declaration of ssize_t, for MS windows

Adrian Buehlmann adrian at cadifra.com
Wed Jul 13 04:05:50 EDT 2016


On 2016-07-13 08:57, Maciej Fijalkowski wrote:
> It's additionally blocking all the other things I want to do on
> mercurial, for really no reason whatsoever
> 
> On Wed, Jul 13, 2016 at 8:55 AM, Maciej Fijalkowski <fijall at gmail.com> wrote:
>> can you guys commit the way you want it please? We've been
>> bikeshedding this simple change for like a week now. I have absolutely
>> zero opinion, I want to be able to use ssize_t. For all practical
>> purposes you can say typedef intptr_t ssize_t, but it does not work on
>> DOS16 or something like that

I don't like the additional #include of a Windows specific header you
added in your proposed patch and I made a proposal how to do it instead.

I'm primarily interested in keeping things working. If you want to give
up on your patches, then I'm perfectly fine with that.

I'd say that replying with a rant certainly won't help getting things
done any faster.

Perhaps just simply use my proposal and send a revised version of your
patch?


More information about the Mercurial-devel mailing list