[PATCH 1 of 3] bdiff: use ssize_t everywhere
Maciej Fijalkowski
fijall at gmail.com
Thu Jul 14 09:51:22 EDT 2016
On Thu, Jul 14, 2016 at 1:59 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
> On 2016-07-14 13:08, Maciej Fijalkowski wrote:
>> # HG changeset patch
>> # User Maciej Fijalkowski <fijall at gmail.com>
>> # Date 1468395384 -7200
>> # Wed Jul 13 09:36:24 2016 +0200
>> # Node ID 98a1290a6af89b3146d28388c30dc24b9b7219f8
>> # Parent 1a1612ddd9721f196690e1fa0831764b43fc6c6e
>> bdiff: use ssize_t everywhere
> ^^^^^^^^^^
> The subject line doesn't match the patch content, as there are still
> uses of Py_ssize_t in bdiff.c after applying this patch.
It uses ssize_t in places that are later copied to a different file. I
did not want to touch lines that are irrelevant
as to not introduce changes that are completely unnecessary. What
would you want instead?
>
>> diff -r 1a1612ddd972 -r 98a1290a6af8 mercurial/bdiff.c
>> --- a/mercurial/bdiff.c Mon Jul 11 13:53:35 2016 +0200
>> +++ b/mercurial/bdiff.c Wed Jul 13 09:36:24 2016 +0200
>> @@ -15,12 +15,13 @@
>> #include <string.h>
>> #include <limits.h>
>>
>> +#include "compat.h"
>> #include "util.h"
>> #include "bitmanipulation.h"
>>
>> struct line {
>> int hash, n, e;
>> - Py_ssize_t len;
>> + ssize_t len;
>> const char *l;
>> };
>>
>> @@ -34,7 +35,7 @@
>> struct hunk *next;
>> };
>>
>> -static int splitlines(const char *a, Py_ssize_t len, struct line **lr)
>> +static int splitlines(const char *a, ssize_t len, struct line **lr)
>> {
>> unsigned hash;
>> int i;
More information about the Mercurial-devel
mailing list