[PATCH] url: add distribution and version to user-agent request header (BC)

[Sean Farley]

Gregory Szorc <gregory.szorc at gmail.com> writes:

> On Thu, Jul 14, 2016 at 10:48 AM, Augie Fackler <raf at durin42.com> wrote:
>
>> On Wed, Jul 13, 2016 at 10:18:26PM -0700, Gregory Szorc wrote:
>> > # HG changeset patch
>> > # User Gregory Szorc <gregory.szorc at gmail.com>
>> > # Date 1468473406 25200
>> > #      Wed Jul 13 22:16:46 2016 -0700
>> > # Node ID 6ad61d5001b1fbfebf317d0557f158d4b34a0772
>> > # Parent  52433f89f816e21ca992ac8c4a41cba0345f1b73
>> > url: add distribution and version to user-agent request header (BC)
>>
>> It's actually intentional that we don't advertise hg version in either
>> direction to my recollection.
>
>
> Do you know why?

If I recall, it was to force people to properly program against
capabilities and not versions.

>> That said, I have been meaning to write
>> a patch like this (but with it behind a config knob) so that big
>> companies can track how many versions of hg are in use. Can you do a
>> v2 with this off by default behind a config knob?
>>
>
> I /can/. But I'm not thrilled about making it optional because open source
> projects (like Mozilla) don't have a good way of force turning it on :/

I agree here. I'd either want this on all the time or not at all.