[PATCH 1 of 3] bdiff: use ssize_t everywhere
adrian at cadifra.com
Fri Jul 15 02:38:20 EDT 2016
On 2016-07-14 15:51, Maciej Fijalkowski wrote:
> On Thu, Jul 14, 2016 at 1:59 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> On 2016-07-14 13:08, Maciej Fijalkowski wrote:
>>> # HG changeset patch
>>> # User Maciej Fijalkowski <fijall at gmail.com>
>>> # Date 1468395384 -7200
>>> # Wed Jul 13 09:36:24 2016 +0200
>>> # Node ID 98a1290a6af89b3146d28388c30dc24b9b7219f8
>>> # Parent 1a1612ddd9721f196690e1fa0831764b43fc6c6e
>>> bdiff: use ssize_t everywhere
>> The subject line doesn't match the patch content, as there are still
>> uses of Py_ssize_t in bdiff.c after applying this patch.
> It uses ssize_t in places that are later copied to a different file. I
> did not want to touch lines that are irrelevant
> as to not introduce changes that are completely unnecessary. What
> would you want instead?
Perhaps, it would be less confusing if you would reorganize your patches
and do the file split first and then replace Py_ssize_t in the split part?
More information about the Mercurial-devel