[PATCH 01 of 11 V4] hgweb: pass ui into preparehttpserver

Yuya Nishihara yuya at tcha.org
Fri Jul 15 09:40:24 EDT 2016


On Thu, 14 Jul 2016 21:16:51 -0700, Gregory Szorc wrote:
> This series includes patches that have already landed on the committed
> repo. The first two patches shouldn't be controversial. They are included
> in case it is decided to wipe out all my draft changesets currently on the
> committed repo.
> 
> Patches 3 to 7 are a refactor what has already landed on the committed repo
> to avoid create_default_context. They should be an easy review.

The patch 1-4 look good to me. The patch 5 looks okay, but I slightly prefer
the previous version if we're sure we can use create_default_context() for
CLIENT_AUTH.

I've marked these patches as "2nd review requested." I can't do bulk rebasing
right now since I'm unsure about the patch 5, and I except it will be settled
while I'm in bed.

I haven't read the other patches yet.


More information about the Mercurial-devel mailing list