[PATCH v2] osutil: add darwin-only version of os.listdir using cffi

Maciej Fijalkowski fijall at gmail.com
Mon Jul 18 07:10:07 EDT 2016


On Fri, Jul 15, 2016 at 1:11 PM, Jun Wu <quark at fb.com> wrote:
> Excerpts from Maciej Fijalkowski's message of 2016-07-15 09:58:59 +0200:
>> I would prefer for setup.py not to grow indefinitely (it's already
>> huge) which directory you want it?
>
> I think reviewers with push access can answer this question better.
> Personally I feel you will get less objections and move faster if just use
> setup.py (scope the logic in a function or class).
>
>> cffi does not support __attribute__(packed), so we can't define it
>> like that (maybe there is a better way)
>
> Seems it supports now?
> https://bitbucket.org/cffi/cffi/commits/c5e17441bc96

I found a way around  it, but I would vastly prefer not to rely on
features that would require e.g. not-yet-released version of pypy


More information about the Mercurial-devel mailing list