[PATCH default] fsmonitor: fix for windows 7 and earlier not supporting GetOverlappedResultEx
Wez Furlong
wez at fb.com
Mon Jul 18 12:56:40 EDT 2016
On Fri, Jul 15, 2016 at 01:53:07PM -0400, Olivier Trempe wrote:
> # HG changeset patch
> # User Olivier Trempe <otrempe>
> # Date 1468268295 14400
> # Mon Jul 11 16:18:15 2016 -0400
> # Node ID c1706a40f3a1be09ca10de2485b2340a3de8f331
> # Parent 9d02bed8477bec7f679d6aeb5b1dd8bcdb80f64d
> fsmonitor: fix for windows 7 and earlier not supporting GetOverlappedResultEx
>
> diff -r 9d02bed8477b -r c1706a40f3a1 hgext/fsmonitor/pywatchman/__init__.py
> --- a/hgext/fsmonitor/pywatchman/__init__.py Tue Jul 12 22:26:04 2016 -0700
> +++ b/hgext/fsmonitor/pywatchman/__init__.py Mon Jul 11 16:18:15 2016 -0400
Nice :-)
Please also submit this as a PR against:
https://github.com/facebook/watchman/tree/master/python/pywatchman
We have a Windows CI system that can help detect issues.
I haven't had a chance to review this code yet, but did write some C code to
handle this compatibility case inside watchman itself; that code is this
module:
https://github.com/facebook/watchman/blob/master/stream_win.c
Thanks!
--Wez.
More information about the Mercurial-devel
mailing list