[Bug 5302] New: util.versiontuple() fails to parse "-rc" version strings

mercurial-bugs at selenic.com mercurial-bugs at selenic.com
Tue Jul 19 02:47:43 EDT 2016


https://bz.mercurial-scm.org/show_bug.cgi?id=5302

            Bug ID: 5302
           Summary: util.versiontuple() fails to parse "-rc" version
                    strings
           Product: Mercurial
           Version: 3.9-rc
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: Mercurial
          Assignee: bugzilla at selenic.com
          Reporter: gregory.szorc at gmail.com
                CC: mercurial-devel at selenic.com

util.versiontuple() is failing to parse version strings like "3.9-rc." It only
correctly parses the major version and fails on the minor version because it
splits on "." sees "9-rc" and gives up after failing to convert it to an int,
returning something like (3, None) or (3, None, None) depending on how many
version components you ask for.

This in turn causes extensions using "minimumhgversion" to not load because the
version comparison code used in extensions.py is only seeing the version "3".

It looks like I introduced this bug ~9 months ago in 39c14e89b881 but I didn't
notice until now because minimumhgversion is a bit younger.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list