[PATCH STABLE] extdiff: escape path for docstring (issue5301)

Yuya Nishihara yuya at tcha.org
Wed Jul 27 09:37:55 EDT 2016


On Tue, 26 Jul 2016 12:45:00 -0500, Matt Mackall wrote:
> On Tue, 2016-07-26 at 21:58 +0900, Yuya Nishihara wrote:
> > On Mon, 25 Jul 2016 16:26:03 -0500, Matt Mackall wrote:
> > > This has the side-effect that the line containing the path is now
> > > variable by the time it reaches _() and thus can't be translated.
> > That's unfortunate, but the direction of this patch seems legit. Maybe
> > we can rephrase the docstring to not include %(path)s in sentence.
> 
> That's probably the right answer, since we have exactly one user at present.

I'll send patches when the freeze is over.

I want to refactor save() closure to a top-level class so that its __doc__
can be collected. Otherwise, we couldn't introduce new i18n strings in addition
to the existing extdiff() command.


More information about the Mercurial-devel mailing list