[PATCH] histedit: use the unfiltered repository to get rulectx

[Augie Fackler]

On Fri, Jun 03, 2016 at 09:22:57PM +0200, Pierre-Yves David wrote:
>
>
> On 06/03/2016 04:54 PM, timeless wrote:
> > # HG changeset patch
> > # User timeless <timeless at mozdev.org>
> > # Date 1464965033 0
> > #      Fri Jun 03 14:43:53 2016 +0000
> > # Node ID bdcf6e2abe8ff449de33fb58d2488f7f60564e22
> > # Parent  9ac309946df9e69bb73ded75f2fc5b84a4e785c2
> > # Available At https://bitbucket.org/timeless/mercurial-crew
> > #              hg pull https://bitbucket.org/timeless/mercurial-crew -r bdcf6e2abe8f
> > histedit: use the unfiltered repository to get rulectx
> >
> > Without this, histedit fails if a node was pruned.
> > But histedit just wants the commit info, it does not need to care if
> > a node is dead or alive.
>
> I'm not super excited by this. This would give histedit access to a
> bunch a hidden not possibly silently leading to issue.

I'm inclined to agree with this - it feels wrong to let histedit
potentially create divergence accidentally.

>
> The way we have been doing this for rebase (and maybe part of histedit)
> is that these command keep a list of involved changesets and these are
> prevented from being hidden while the operation proceed.
>
> Cheers,
>
> --
> Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel