[PATCH 1 of 2] test-chg: run only with chg

Yuya Nishihara yuya at tcha.org
Mon Jun 6 10:22:50 EDT 2016


On Mon, 6 Jun 2016 07:04:14 +0200, Pierre-Yves David wrote:
> On 05/29/2016 03:40 PM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1458511143 25200
> > #      Sun Mar 20 14:59:03 2016 -0700
> > # Node ID f4d797228ecddcebfe86a9f726cdd55df49ef874
> > # Parent  9da137faaa9c9593f821923189316e7fcb38cf67
> > test-chg: run only with chg
> > 
> > It doesn't make sense to run test-chg.t without chg, so ignore it with vanilla
> > hg, and specify chg executable explicitly.
> > 
> > test-chg.t can host chg-specific tests.  
> 
> I'm still a bit puzzle by the mechanism here. In my opinion it would
> make sense to test if chg works in all case, that way if someone
> introduce something that break the basic chg principle we would detect
> it in all cases.
>
> Having this running only if --chg is specify defeat this principle. Are
> we building (and making available) chg in all case? or only when we use it?

chg is built and its setup/cleanup processes are run only when --chg/--with-chg
specified. We could change that, but it will require more work. Also, I don't
think running test-chg.t is enough to say nothing broken.


More information about the Mercurial-devel mailing list