[PATCH 2 of 5] revlog: use hashlib.sha1 directly instead of through util

[Gregory Szorc]

On Fri, Jun 10, 2016 at 2:36 PM, Augie Fackler <raf at durin42.com> wrote:

>
> > On Jun 10, 2016, at 4:47 PM, Matt Mackall <mpm at selenic.com> wrote:
> >
> > On Fri, 2016-06-10 at 00:41 -0400, Augie Fackler wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <raf at durin42.com>
> >> # Date 1465531834 14400
> >> #      Fri Jun 10 00:10:34 2016 -0400
> >> # Node ID bd2caf6762219aba40edd4dd697fee70de306940
> >> # Parent  16f5b31b1228212dc175b5a0baf3601cca48330d
> >> revlog: use hashlib.sha1 directly instead of through util
> >>
> >> Also remove module-local _sha alias, which was barely used.
> >
> > @@ -40,7 +41,6 @@ from . import (
> >>  _unpack = struct.unpack
> >>  _compress = zlib.compress
> >>  _decompress = zlib.decompress
> >> -_sha = util.sha1
> >
> > These are each a micro-optimization on Python's abysmal lookup path.
>
> Ugh. Does it make a measurable difference on a perf command?
>

I would go for a revset that accesses non-indexed changelog revision data.
Something like author() or date(). That will perform a sha1 for every
changeset without involving too many other operations.


>
> >
> > --
> > Mathematics is the supreme nostalgia of our time.
> >
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel at mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160610/1cdb7b1b/attachment.html>