[PATCH 3 of 4] hgweb: add ancestors blame info in annotate hgweb template

Yuya Nishihara yuya at tcha.org
Sun Jun 12 01:25:11 EDT 2016


On Fri, 10 Jun 2016 19:07:16 -0700, Gregory Szorc wrote:
> > On Jun 9, 2016, at 05:26, Denis Laxalde <denis.laxalde at logilab.fr> wrote:
> > 
> > Yuya Nishihara a écrit :  
> >>> On Mon, 06 Jun 2016 10:03:19 +0200, Denis Laxalde wrote:
> >>> # HG changeset patch
> >>> # User Denis Laxalde <denis.laxalde at logilab.fr>
> >>> # Date 1464943305 -7200
> >>> #      Fri Jun 03 10:41:45 2016 +0200
> >>> # Node ID ecadc1da55f84fd77110ca23341e12949110d46c
> >>> # Parent  632a34ed3b63420e1444cb4c3a09a0692b274615
> >>> hgweb: add ancestors blame info in annotate hgweb template
> >>> 
> >>> In gitweb style, display this ancestors information in a new column on the
> >>> left of the revision's one.  
> >> 
> >> I know it is useful to navigate to the parent revision, but this seems a bit
> >> verbose. The parent revision has no relation to the line where it is displayed.  
> > 
> > That's true. For the record, I'm trying to address item "hgweb links to ancestor's blame" of https://www.mercurial-scm.org/wiki/BlamePlan. (Cc Gregory would originally wrote this plan.)
> > 
> > In fact, I later realized that there already was a link to parent's annotate view in the header section of the gitweb template that serves quite the same purpose. So to avoid "cluttering" the interface, maybe we could suggest a 2-steps navigation:
> > 1) click on some link in the first column of the annotate view, leading the annotate view at this revision, then,
> > 2) navigate to parent(s) annotate view from the header of the page.
> > 
> > What do you think?  
> 
> The specific workflow I'd like to see optimized is navigating to earlier annotate views faster. Currently you have to go to a line then find a link possibly multiple pages away to the parent then find the original source line in that rendered view. Having a link to the parent's annotation for that line on a line/block removes 2 potentially time consuming scrolling steps and would be a massive win for traveling back in time in the annotation view.
> 
> This unfortunately requires some kind of clutter. Perhaps we could hide links unless there is mouseover/hover?

Or make links less informative.

  mpm at 22046 [^]  1 #require git

instead of

  ede at 12992  mpm at 22046  1 #require git

I don't like the latter because ede at 12992 looks like saying something related
to the line 1, but actually it is only the parent of 22046 in filelog.


More information about the Mercurial-devel mailing list