[PATCH RFC] ui: provide official way to reset internal state per command

Augie Fackler raf at durin42.com
Mon Jun 13 20:41:07 EDT 2016


Queued, thanks

> On Jun 12, 2016, at 7:54 AM, Jun Wu <quark at fb.com> wrote:
> 
> This looks good to me. It does not conflict with my ui refactoring idea,
> although the refactor won't come soon.
> 
> For ui, I'd prefer simper apis and wonder if we have alternative options.
> 
> Extensions can always wrap functions to do whatever they want. It's possible
> to do extension-specific reset state by wrapping dispatch.runcommand. And
> progbar.resetstate() looks like progress.py specific.
> 
> Consider the fact progress.py is in core, wrapping looks strange, I think
> it's reasonable to just move progbar.resetstate() to dispatch.py.
> 
> Excerpts from Yuya Nishihara's message of 2016-06-12 14:31:15 +0900:
>> # HG changeset patch
>> # User Yuya Nishihara <yuya at tcha.org>
>> # Date 1465708046 -32400
>> #      Sun Jun 12 14:07:26 2016 +0900
>> # Node ID 58d3b0dd7f03e318fb534103b39bf93aeb4c03b1
>> # Parent  c27dc3c31222c7f74331221a3d25566146feecac
>> ui: provide official way to reset internal state per command

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160613/d6d04443/attachment.sig>


More information about the Mercurial-devel mailing list