[Bug 5266] New: amend uses old commit message after waiting on lock

[mercurial-bugs at selenic.com]

https://bz.mercurial-scm.org/show_bug.cgi?id=5266

            Bug ID: 5266
           Summary: amend uses old commit message after waiting on lock
           Product: Mercurial
           Version: 3.8-rc
          Hardware: PC
                OS: Mac OS
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: evolution
          Assignee: bugzilla at selenic.com
          Reporter: martinvonz at google.com
                CC: mercurial-devel at selenic.com,
                    pierre-yves.david at ens-lyon.org

It has happened once or twice that I have had the editor for "hg commit
--amend" open, seen something that needed to be fixed in the code, and run "hg
amend" in another window without thinking about the running "hg commit
--amend". When I close the editor and "hg amend" gets a chance to run, it
overwrites my updated commit message with the old one.

The below demonstrates the problem, although it's not 100% reliable:

hg init
echo a > file
hg ci -Aqm initial

cat > editor <<EOF
#!/bin/sh
echo updated > \$1
sleep 1
EOF
chmod +x editor

HGEDITOR=./editor hg ci --amend & (echo x >> file; hg amend)
hg log -T'{desc}'

This prints "initial". I would have expected "updated".

-- 
You are receiving this mail because:
You are on the CC list for the bug.