[PATCH 2 of 3] url: remember http password database in ui object

Piotr Listkiewicz piotr.listkiewicz at gmail.com
Mon Jun 20 05:21:27 EDT 2016


>
> You don't have to alias urlreq unless you have any particular reason.


This is only because with alias it is easier to fit in 81 character limit
in line :P

2016-06-18 15:35 GMT+02:00 Yuya Nishihara <yuya at tcha.org>:

> On Tue, 14 Jun 2016 11:13:30 +0200, liscju wrote:
> > # HG changeset patch
> > # User liscju <piotr.listkiewicz at gmail.com>
> > # Date 1465465296 -7200
> > #      Thu Jun 09 11:41:36 2016 +0200
> > # Node ID 62fac77f1cd9e4270b2db7a7a987bc12783b41a8
> > # Parent  5ac51055840cf0031d8407f722784ce26f152079
> > url: remember http password database in ui object
>
> > --- a/mercurial/ui.py
> > +++ b/mercurial/ui.py
> > @@ -29,6 +29,8 @@ from . import (
> >      util,
> >  )
> >
> > +urlreq = util.urlreq
>
> You don't have to alias urlreq unless you have any particular reason.
>
> > @@ -124,6 +126,8 @@ class ui(object):
> >              self.callhooks = src.callhooks
> >              self.insecureconnections = src.insecureconnections
> >              self.fixconfig()
> > +
> > +            self.httppasswordmgrdb = src.httppasswordmgrdb
> >          else:
> >              self.fout = sys.stdout
> >              self.ferr = sys.stderr
> > @@ -135,6 +139,8 @@ class ui(object):
> >              for f in scmutil.rcpath():
> >                  self.readconfig(f, trust=True)
> >
> > +            self.httppasswordmgrdb =
> urlreq.httppasswordmgrwithdefaultrealm()
>
> Can you update this patch to reinitialize httppasswordmgrdb on
> resetstate() ?
>
> Other than that, the series looks good to me.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160620/25e68d31/attachment.html>


More information about the Mercurial-devel mailing list