[PATCH 5 of 5 V2] templates: add support for graph webcommand in json style

Laura Médioni laura.medioni at logilab.fr
Mon Jun 20 09:29:58 EDT 2016


On 06/20/2016 03:24 PM, Yuya Nishihara wrote:
> On Mon, 20 Jun 2016 11:02:23 +0200, Laura Médioni wrote:
>> On 06/16/2016 12:16 PM, Anton Shestakov wrote:
>>> 15.06.2016, 22:48, "Laura Médioni" <laura.medioni at logilab.fr>:
>>>>    # HG changeset patch
>>>>    # User Laura Médioni <laura.medioni at logilab.fr>
>>>>    # Date 1465806567 -7200
>>>>    # Mon Jun 13 10:29:27 2016 +0200
>>>>    # Node ID 9fc3e7b7ea8f8d77e4167dfa5c63ee2c37d3690d
>>>>    # Parent 33c362973b2ab07b2e20d6818b7e72473e682fd4
>>>>    templates: add support for graph webcommand in json style
>>> There doesn't seem to be anything wrong with this patch, but after the previous ones that display that nice self-describing format for data, where things are just self-explanatory and are easy to get, this one just pains me.
>>>
>>> Do you have any plans to improve graph in hgweb? Can we expose data in a better structure?
>>>
>>> Just look at this ugly sucker:
>> I agree this is unreadable. I reused the data structure that was created
>> for the js widget that currently displays the graph.
>> The truth is I doubt this is useful outside this context, and if we
>> wanted to expose graph data we should do it with a better structure.
>> I don't know is there is right now a real need for such a thing...
>> Actually we hadn't planned to spend more time on it and maybe the best
>> thing would just be to kill this changeset.
> So should we drop it from your V3 series?
>
> https://patchwork.mercurial-scm.org/patch/15551/

If it is OK for everyone, yes, it can be dropped. I was waiting for a 
confirmation.

-- 
Laura Médioni - LOGILAB, Toulouse ((+33) 5 62 17 16 42)


More information about the Mercurial-devel mailing list