[PATCH 1 of 5 V3] templates: add support for filelog webcommand in json style

Anton Shestakov engored at ya.ru
Mon Jun 20 10:14:04 EDT 2016


20.06.2016, 17:25, "Laura Médioni" <laura.medioni at logilab.fr>:
> # HG changeset patch
> # User Laura Médioni <laura.medioni at logilab.fr>
> # Date 1464946102 -7200
> # Fri Jun 03 11:28:22 2016 +0200
> # Node ID 53f73556559ade2e726e9355b521dcbd95ae4dae
> # Parent 4e6e280e238fa885df9e0e600dc5915a71c8a37a
> templates: add support for filelog webcommand in json style

But then

> Modify changelistentry structure to also deliver phase and branch data and use
> either 'parents' or 'allparents' depending on what is defined in the view, in
> order to reuse it in filelog structure.

This should be a separate patch with a commit message documenting why can't we, for example, just use "changeset" as is.

Making separate patches for different things helps reviewing them now, and giving reasons right in the commit message helps working with this code in future.

Admittedly, in this case it may not be a big deal, but in general, understanding the reasoning behind a patch mustn't involve searching mailing lists, because it could take absolute ages.


More information about the Mercurial-devel mailing list