[PATCH 3 of 5 V3] templates: add support for summary webcommand in json style

Anton Shestakov engored at ya.ru
Mon Jun 20 10:44:13 EDT 2016


20.06.2016, 22:34, "Yuya Nishihara" <yuya at tcha.org>:
> On Mon, 20 Jun 2016 22:20:20 +0800, Anton Shestakov wrote:
>>  20.06.2016, 17:25, "Laura Médioni" <laura.medioni at logilab.fr>:
>>  > # HG changeset patch
>>  > # User Laura Médioni <laura.medioni at logilab.fr>
>>  > # Date 1465218851 -7200
>>  > # Mon Jun 06 15:14:11 2016 +0200
>>  > # Node ID ad0ee6b2ebd8a442b308c3148fc18c2235aa7a88
>>  > # Parent 7e920504e0310edef1f2565ba4cf7edd309c6434
>>  > templates: add support for summary webcommand in json style
>
>>  > + {
>>  > + "archives": [],
>>
>>  Can we have a list of archives in the test here?
>
> I don't think "archives" is useful in JSON output. It says
>
>   "archives": [
>     {
>       "node": "tip",
>       "extension": ".tar.gz",
>       "type": "gz"
>     }
>   ]
>
> so what?
>
> Can we just remove "archives" ?

We can, but how about improve instead?

I'd say having an absolute URL for downloading an archive here would be useful. Probably "extension" can go away. Something like this looks alright:

   "archives": [
     {
       "node": "tip",
       "url": "https://code.example.com/user/project/archive/tip.tar.gz",
       "type": "gz"
     }
   ]

Not sure how useful "node" is right now... But we could add more things there? Maybe branches, tags (or should I say "more tags", because "tip") or bookmarks?


More information about the Mercurial-devel mailing list