[PATCH] journal: new expiremental extension

Martijn Pieters mj at zopatista.com
Mon Jun 20 12:47:34 EDT 2016


On 19 June 2016 at 15:32, Yuya Nishihara <yuya at tcha.org> wrote:
> On Fri, 17 Jun 2016 13:03:00 -0700, Durham Goode wrote:
>> > +class journalstorage(object):
>> > +    def __init__(self, repo):
>> > +        self.repo = repo
>> > +        self.user = util.getuser()
>> > +        if repo.shared():
>> > +            self.vfs = scmutil.vfs(repo.sharedpath)
>> > +        else:
>> > +            self.vfs = repo.vfs
>> Hmm, I wonder how the journal will work with shared working copies.
>> Like, we may need to store the '.' reference with information about the
>> which working copy was moved.  We can figure that out later.
>
> Perhaps we'd better start without the shared vfs? The sharedpath directory
> isn't covered by repo.wlock, so the journal file could be corrupted.

Good point; I've sent V2 without shared vfs support for now and figure
this out in a separate patch later on.

-- 
Martijn Pieters


More information about the Mercurial-devel mailing list