[PATCH V2] bookmarks: add 'hg pull -B .' for pulling the active bookmark (issue5258)

Yuya Nishihara yuya at tcha.org
Tue Jun 21 08:34:44 EDT 2016


On Mon, 20 Jun 2016 14:15:30 -0700, Sean Farley wrote:
> >> +++ b/mercurial/exchange.py
> >> @@ -1056,7 +1056,8 @@ class pulloperation(object):
> >>          # revision we try to pull (None is "all")
> >>          self.heads = heads
> >>          # bookmark pulled explicitly
> >> -        self.explicitbookmarks = bookmarks
> >> +        self.explicitbookmarks = [repo._bookmarks.expandname(bookmark)
> >> +                                  for bookmark in bookmarks]  
> >
> > I have no idea where '.' should be expanded, but it seems inconsistent that
> > pulloperation keeps expanded names but pushoperation doesn't. Thoughts?  
> 
> To add from a previous mail about this, I think we should expand '.' in
> the bookmark class (or util) and permanently reserve '.' from all
> namespaces. Are there any corner-cases to think about here?

I feel like saying it sounds nice, but actually I don't get it. The bookmark
class isn't involved to process the explicitbookmarks in updatefromremote().


More information about the Mercurial-devel mailing list