[PATCH 1 of 4 V6] hgweb: highlight data of the current revision in annotate view

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Jun 21 13:29:26 EDT 2016


I really like the set of feature that this series bring but I'm not very
convinced by their visual rendering

* I like the change in to color for the *link* to the current revision,
but the green *text* (for the content) is far too subtle to me. We
should have something stronger like background color change or something,

* The blocking per similar revision in a good idea, but on large block
this is confusing, I end up having to scroll up for a long time to grab
the link at the start of the block, we should probably think about
something else. For example (random brain storming) we could have the
link dimmed out until you hover your mouse on it. Alternatively, a link
jumping to the start of the block might do.

* I link the fact we have more useful link available when we over on
something. However. I see two issues with it. First, the box is very raw
and a bit cryptic. we should extend the text to make them more explicit.
In addition, from a pure visual perspective, the margin seems too small.
Try to get a graphist to adjust them for you (I heard you have access to
one now ☺)

So to summarize, I link the underlying, but I've reservation on the
visual (as in, I would not like to release them like this).

>From here I can see multiple paths

1) We do a couple round-trip to agree on a new look,
2) We extract the look from the html change, we take the html change
(semantic part) and we iterate on the rendering,
3) We proceed as is, hiding the new feature behind an experimental flag
until we have happy of how they look,
4) Majority of people like it as is and we proceed as is.

On 06/16/2016 03:58 PM, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde at logilab.fr>
> # Date 1464877610 -7200
> #      Thu Jun 02 16:26:50 2016 +0200
> # Node ID 6ef96d3a3dc685edabc0f5ef653c31d9fece2916
> # Parent  60621cecc8c53d3a27e9984fb06fefc1f99797b3
> hgweb: highlight data of the current revision in annotate view
> 
> * Distinguish the /annotate/<revision>/<file>#<linenumber> link when it would
>   lead to the current page (i.e. <revision> is the current revision) (style it
>   gray and undecorated). This indicates more clearly that this is a "dead-end"
>   in blame navigation.
> 
> * Display lines changed in current revision in green.
> 

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list