[PATCH 2 of 6 V3] revset: insert _reorder to fix ordering of inner 'or' and functions (BC)

Yuya Nishihara yuya at tcha.org
Wed Jun 22 11:42:25 EDT 2016


On Fri, 17 Jun 2016 23:45:28 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1455629461 -32400
> #      Tue Feb 16 22:31:01 2016 +0900
> # Node ID a99114251d721a469991574105d1a0167f4fb162
> # Parent  defa6a51c4613a4294db3a16a3dea7b5cb6025a0
> revset: insert _reorder to fix ordering of inner 'or' and functions (BC)

> + at predicate('_reorder(set)', safe=True)
> +def _reorder(repo, subset, x):
> +    # Evaluate right-hand-side expression 'set' and reorder the result set
> +    # according to the left-hand-side set 'subset'
> +    rs = getset(repo, subset, x)
> +    return subset & rs

I'll change this to

    rs = getset(repo, fullreposet(repo), x)
    return subset & rs

This will avoid extra filtering by subset.


More information about the Mercurial-devel mailing list