[PATCH 2 of 4] atomictempfile: remove test ordering

Martijn Pieters mj at zopatista.com
Thu Jun 23 12:43:59 EDT 2016


# HG changeset patch
# User Martijn Pieters <mjpieters at fb.com>
# Date 1466700058 -3600
#      Thu Jun 23 17:40:58 2016 +0100
# Node ID 3b77e79175cdbb148ad78fc6beedee4dd16bf4c0
# Parent  f06a3b48a4b3f7beed5405e4f157c5734b68e59e
atomictempfile: remove test ordering

These tests are independent and numbering only makes it harder to add more and
logically group them.

diff --git a/tests/test-atomictempfile.py b/tests/test-atomictempfile.py
--- a/tests/test-atomictempfile.py
+++ b/tests/test-atomictempfile.py
@@ -19,7 +19,7 @@
     def tearDown(self):
         shutil.rmtree(self._testdir, True)
 
-    def test1_simple(self):
+    def test_simple(self):
         file = atomictempfile(self._filename)
         self.assertFalse(os.path.isfile(self._filename))
         tempfilename = file._tempname
@@ -34,7 +34,7 @@
             os.path.join(self._testdir, '.testfilename-*')))
 
     # discard() removes the temp file without making the write permanent
-    def test2_discard(self):
+    def test_discard(self):
         file = atomictempfile(self._filename)
         (dir, basename) = os.path.split(file._tempname)
 
@@ -46,11 +46,11 @@
 
     # if a programmer screws up and passes bad args to atomictempfile, they
     # get a plain ordinary TypeError, not infinite recursion
-    def test3_oops(self):
+    def test_oops(self):
         self.assertRaises(TypeError, atomictempfile)
 
     # checkambig=True avoids ambiguity of timestamp
-    def test4_checkambig(self):
+    def test_checkambig(self):
         def atomicwrite(checkambig):
             f = atomictempfile(self._filename, checkambig=checkambig)
             f.write('FOO')


More information about the Mercurial-devel mailing list