[PATCH] largefiles: fix misleading comments in lfutil instore and storepath

liscju piotr.listkiewicz at gmail.com
Fri Jun 24 07:11:11 UTC 2016


# HG changeset patch
# User liscju <piotr.listkiewicz at gmail.com>
# Date 1466752096 -7200
#      Fri Jun 24 09:08:16 2016 +0200
# Node ID b729be184fb36c8399e68c026f661e61a9ddef74
# Parent  6d96658a22b0fc1eb210c99c5629dd69fedf3006
largefiles: fix misleading comments in lfutil instore and storepath

Problem in both cases is cache in largefiles has assigned
meaning - user cache which is additional place to get/put
files. Those two function works on store - the main place
to store largefiles in the repository - .hg/largefiles and
using "cache" to describe it is misleading.

diff --git a/hgext/largefiles/lfutil.py b/hgext/largefiles/lfutil.py
--- a/hgext/largefiles/lfutil.py
+++ b/hgext/largefiles/lfutil.py
@@ -190,12 +190,11 @@ def listlfiles(repo, rev=None, matcher=N
             if rev is not None or repo.dirstate[f] != '?']
 
 def instore(repo, hash, forcelocal=False):
-    '''Return true if a largefile with the given hash exists in the user
-    cache.'''
+    '''Return true if a largefile with the given hash exists in the store'''
     return os.path.exists(storepath(repo, hash, forcelocal))
 
 def storepath(repo, hash, forcelocal=False):
-    '''Return the correct location in the repository largefiles cache for a
+    '''Return the correct location in the repository largefiles store for a
     file with the given hash.'''
     if not forcelocal and repo.shared():
         return repo.vfs.reljoin(repo.sharedpath, longname, hash)


More information about the Mercurial-devel mailing list