[PATCH 3 of 4 v2] policy: add cffi policy for PyPy

Maciej Fijalkowski fijall at gmail.com
Mon Jun 27 10:38:35 EDT 2016


On Mon, Jun 27, 2016 at 3:39 PM, Yuya Nishihara <yuya at tcha.org> wrote:
> On Thu, 23 Jun 2016 08:57:10 +0200, Maciej Fijalkowski wrote:
>> # HG changeset patch
>> # User Maciej Fijalkowski <fijall at gmail.com>
>> # Date 1465306558 -7200
>> #      Tue Jun 07 15:35:58 2016 +0200
>> # Node ID 42e8ffc4adb694a2a0a4787e129aa4e7d0296631
>> # Parent  f5a166fffae1ade1e5b7bcad759a3899813bd91f
>> policy: add cffi policy for PyPy
>>
>> This adds cffi policy in the case where we don't want to use C modules,
>> but instead we're happy to rely on cffi (bundled with pypy)
>>
>> diff -r f5a166fffae1 -r 42e8ffc4adb6 mercurial/__init__.py
>> --- a/mercurial/__init__.py   Tue Jun 07 14:44:04 2016 +0200
>> +++ b/mercurial/__init__.py   Tue Jun 07 15:35:58 2016 +0200
>> @@ -59,7 +59,7 @@
>>                  return zl
>>
>>              try:
>> -                if modulepolicy == 'py':
>> +                if modulepolicy in policynoc:
>
> The policynoc constant is missing in this patch. Other than that, this patch
> looks good to me.

That's because stuff got shuffled in the meantime and now it belongs
somewhere else (meh it's in patch 4 of 4 of course). It would be
vaaaastly easier if you guys could commit patches in chunks. Right now
I need to get all 4 to be proper before it gets accepted, when say 2
or 3 gets out of date (but is otherwise uncontroversial).


More information about the Mercurial-devel mailing list