[PATCH 1 of 4 v2] internals: move the bitmanipulation routines into its own file
Yuya Nishihara
yuya at tcha.org
Tue Jun 28 08:24:05 EDT 2016
On Mon, 27 Jun 2016 16:53:29 +0200, Maciej Fijalkowski wrote:
> On Mon, Jun 27, 2016 at 2:58 PM, Yuya Nishihara <yuya at tcha.org> wrote:
> > On Thu, 23 Jun 2016 08:57:08 +0200, Maciej Fijalkowski wrote:
> >> # HG changeset patch
> >> # User Maciej Fijalkowski <fijall at gmail.com>
> >> # Date 1465211293 -7200
> >> # Mon Jun 06 13:08:13 2016 +0200
> >> # Node ID d62df3ee14e3b2cf658c247233bda60def219e0f
> >> # Parent 98e8313dcd9e98c67d65de9ee49c88082406cb3f
> >> internals: move the bitmanipulation routines into its own file
> >>
> >> This is to allow more flexibility with the C sources -- now the
> >> bitmanipulation routines can be safely imported without importing Python.h
> >
> > This removes several typedefs and inline macro from util.h, which appear to
> > cause compile error on Windows.
> >
> > Perhaps we'll need a utility header that does not depend on Python.h,
> > something like util.h and pyutil.h?
>
> Well, the original patch put #include "bitmanipulation.h" into util.h.
> Can I just put it back and then stuff works?
I think that's okay. I don't like the name "bitmanipulation.h" as it has
several utility codes, but that isn't big deal.
More information about the Mercurial-devel
mailing list