[PATCH] hgwatchman: new experimental extension

Augie Fackler raf at durin42.com
Tue Mar 1 13:35:13 EST 2016


On Tue, Mar 01, 2016 at 04:14:36PM +0000, Martijn Pieters wrote:
> On 1 March 2016 at 15:58, Yuya Nishihara <yuya at tcha.org> wrote:
> > Isn't it a library?
> >
> > https://pypi.python.org/pypi/pywatchman
> >
> > IIRC, last time we discussed about bundling "re2", we decided not to.
>
> Golly, I didn't even know it was distributed separately on PyPI. I
> still would prefer bundling this inside the extension though;
> batteries included and all that. Otherwise you need to ask end users
> to install 2 pieces of software rather than one, where watchman is a
> binary and doesn't require knowledge of how Python package installs
> work.

If we're going to bundle it, we should probably bundle it in exactly
one place and also bundle it for core hg so that ignore gets faster.

Probably worth having a "mercurial.thirdparty" namespace so it's easy
for distros to split out the vendored libraries.

>
> --
> Martijn Pieters
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list