[PATCH 03 of 10] chg: drop progress.assume-tty config

Yuya Nishihara yuya at tcha.org
Wed Mar 2 10:32:12 EST 2016


On Wed, 2 Mar 2016 10:44:05 +0000, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1456746205 0
> #      Mon Feb 29 11:43:25 2016 +0000
> # Node ID 855e65accbb4519f7140828efe6800b0b92fd5f4
> # Parent  74f9fd794398e5bebb6271cea53d5e5e5bf5e590
> chg: drop progress.assume-tty config
> 
> Since chgserver will just take over the fds passed from the client. It can
> pass istty check and progress.assume-tty is no longer necessary.
       ~~~~~
       isatty

The change looks good, but the reasoning is wrong. It was necessary to go
through progress.uisetup(). We no longer need it because the progress got
into the core.

(I haven't review the other patches. I'll apply spelling fixes in flight.)


More information about the Mercurial-devel mailing list