[PATCH] transplant: use hex directly

Gregory Szorc gregory.szorc at gmail.com
Wed Mar 2 15:39:32 EST 2016



> On Mar 1, 2016, at 10:41, Augie Fackler <raf at durin42.com> wrote:
> 
>> On Mon, Feb 29, 2016 at 11:30:39PM -0600, timeless wrote:
>> # HG changeset patch
>> # User timeless <timeless at mozdev.org>
>> # Date 1456808023 0
>> #      Tue Mar 01 04:53:43 2016 +0000
>> # Node ID 7e6c4a1aefec8ef0047c58a76e8775b8a14768ff
>> # Parent  c7f89ad87baef87f00c507545dfd4cc824bc3131
>> transplant: use hex directly
> 
> from mercurial.node import hex forces demandimport to resolve the
> module early. Instead reference it as node.hex in this file, and
> import the module.
> 
> (I know 'from mercurial.node import hex' is common throughout hg, but
> I still don't like it.

I'm pretty sure mercurial.node (and tons of other modules) will be imported by the time a command runs. So I don't think there's anything worth worrying about here.


More information about the Mercurial-devel mailing list