[PATCH 6 of 6] blackbox: trap warnings

Yuya Nishihara yuya at tcha.org
Thu Mar 3 11:48:34 EST 2016


On Thu, 3 Mar 2016 08:57:17 -0500, timeless wrote:
> I can put this behind a flag...

A flag won't be necessary because the log is filtered by blackbox.track.
My concern is about the design. I'm not the right person who can tell
the design of the blackbox extension.

> On Mar 3, 2016 8:28 AM, "Yuya Nishihara" <yuya at tcha.org> wrote:
> > On Tue, 01 Mar 2016 05:51:48 -0600, timeless wrote:
> > > # HG changeset patch
> > > # User timeless <timeless at mozdev.org>
> > > # Date 1455219585 0
> > > #      Thu Feb 11 19:39:45 2016 +0000
> > > # Node ID ac01762261adcbf4d996f1a39da0b28c91e2ad34
> > > # Parent  0191718c65ff72d16c42839e4be126d9b565d787
> > > blackbox: trap warnings
> > >
> > > diff --git a/hgext/blackbox.py b/hgext/blackbox.py
> > > --- a/hgext/blackbox.py
> > > +++ b/hgext/blackbox.py
> > > @@ -189,6 +189,11 @@
> > >                  if not lastui or ui._bbrepo:
> > >                      lastui = ui
> > >
> > > +        def warn(self, *msg, **opts):
> > > +            super(blackboxui, self).warn(*msg, **opts)
> > > +            output = ''.join(msg)
> > > +            self.log("blackboxwarn", "%s\n", output)
> >
> > Ugh, do we really want to capture all warnings?


More information about the Mercurial-devel mailing list