[PATCH 04 of 10] chg: drop --cwd /

Yuya Nishihara yuya at tcha.org
Fri Mar 4 08:30:31 EST 2016

On Fri, 4 Mar 2016 11:37:18 +0000, Jun Wu wrote:
> On 03/03/2016 02:44 PM, Yuya Nishihara wrote:
> > I don't like the implicit chdir() introduced by the next patch. Probably we
> > can do "--daemon-postexec chdir:/" instead. It's common for a daemon process
> > to chdir to / once its boot-up sequence is completed.
> Sorry for the late response but I am the London oncall this week and was busy
> handling internal stuffs.
> I think --daemon-postexec chdir:/ works but is not a good fit because:

> - For chgserver, chdir / should be always performed, regardless of what the
>    client says.

No, chdir('/') isn't a requisite. We need it because chg (client) starts a
server at arbitrary locations, and the server is daemonized.

> - It needs extra work to make multiple "postexec" actions (say you want to do
>    both chdir and unlink). Turning --daemon-postexec into a multiple flag will
>    make "--daemon-postexec none" look weird.

Yep, "none" looks weird.

More information about the Mercurial-devel mailing list