[PATCH 07 of 10] chgserver: implement validate command

Yuya Nishihara yuya at tcha.org
Fri Mar 4 08:46:44 EST 2016


On Fri, 4 Mar 2016 11:42:59 +0000, Jun Wu wrote:
> On 03/03/2016 04:06 PM, Yuya Nishihara wrote:
> > It seems awkward that the input has no last '\0', but the output has, though
> > I know validate() have to return something even if insts is empty.
> 
> The input is consistent with runcommand and getpager. Since there are 3
> commands using a same input, I have considered adding another command for just
> passing "args" beforehand. But maintaining compatibility for runcommand is hard
> so I gave up.

I'm okay with "args". My point is that "args" isn't terminated by '\0', so
"insts" shouldn't be terminated by '\0' as well.


More information about the Mercurial-devel mailing list