[PATCH 2 of 4 V3] chg: implement validate in hgclient

Yuya Nishihara yuya at tcha.org
Sun Mar 6 08:28:53 EST 2016


On Sun, 6 Mar 2016 12:57:28 +0000, Jun Wu wrote:
> On 03/06/2016 11:07 AM, Yuya Nishihara wrote:
> > I found unpackcmdargsnul() do the same job. Perhaps we can use it if we take
> > the original free-by-caller design. Though it won't be nice to expose an
> > internally-allocated buffer, it will be simple as there is the function.
> 
> The behavior is a bit different when the buffer has "\0\0". I will use it and
> make sure it's not free by caller.

Hmm, right, but that difference isn't important. FWIW, if free-by-caller makes
the code simpler, please do. I just thought the V1 was unnecessary complicated.


More information about the Mercurial-devel mailing list