[PATCH 3 of 4 V2] graphmod: use different styles for different edge types

Tim Delaney timothy.c.delaney at gmail.com
Tue Mar 8 17:02:26 EST 2016


On 9 March 2016 at 04:42, Durham Goode <durham at fb.com> wrote:

> Your change helps a bunch in the case where ancestors aren't present, but
> that's pretty rare in our code base at least (since we have very few
> merges).  Here is the before and after smartlog output from my hg repo:
> https://bpaste.net/show/2093d7bad9c1
>
> I actually find the dashed line detracts from the general glance-ability
> of the data, and am not sure we'd want to replace smartlog with this output
> just yet.  Is there a config option to disable these line stylings?


How does it look to you if you replace colon (:) with exclamation mark (!)?
Note: need to be a little careful with find/replace to avoid changing
colons in the text. Personally, I don't like it, but it does give a more
solid but broken line.

Another idea - do we need the entire path showing the grandparent
relationship? Would it be enough to just have it at the start (and probably
end) of the path?

@  4932aa  mjpieters
:  graphmod: end edges to missing parents early.
|
| o  d01268  durham
| :  parsers: optimize filtered headrevs logic
| |
| | o  55f8ae  durham
| |/   branchmap: check node against changelog instead of repo
| |
| | o  54f93f  durham  prof
| | |  Add proftimer
| | |
+---o  8a40e9  durham
| |    branchmap: check node against nodemap instead of changelog (for perf)
: |
o |  5cef34  durham  hgvip/release-2016-02-17
| |  test: remove dependency on $PYTHONDIR
| |
o |  4f99a5  durham
| | test: quick fix for test-hook
| |
o |  95bf01  quark  fbcrew/@
| |  chg: forward umask from client to server
| |
o |  e48d77  quark
| |  chgserver: add setumask method
| |

and with merges:

o    changeset:   32:d06dffa21a31
|\   parent:      27:886ed638191b
| :  parent:      31:621d83e11f67
| |  user:        test
| |  date:        Thu Jan 01 00:00:32 1970 +0000
| |  summary:     (32) expand
| |
o |  changeset:   31:621d83e11f67
|\|  parent:      21:d42a756af44d
| |  parent:      30:6e11cd4b648f
| |  date:        Thu Jan 01 00:00:31 1970 +0000
| |  summary:     (31) expand
| |
o |    changeset:   30:6e11cd4b648f
|\ \   parent:      28:44ecd0b9ae99
| ~ |  parent:      29:cd9bb2be7593
|   |  user:        test
|   |  date:        Thu Jan 01 00:00:30 1970 +0000
|   |  summary:     (30) expand
|  /
o |    changeset:   28:44ecd0b9ae99

Tim Delaney
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160309/4fcac4de/attachment.html>


More information about the Mercurial-devel mailing list