[PATCH 3 of 7 iterbatch] peer: add an iterbatcher interface

Augie Fackler raf at durin42.com
Tue Mar 8 20:03:58 EST 2016

> On Mar 8, 2016, at 7:03 PM, Martin von Zweigbergk <martinvonz at google.com> wrote:
>> peer: add an iterbatcher interface
>> This is very much like ordinary batch(), but it will let me add a mode
>> for batch where we have pathologically large requests which are then
>> handled streamily. This will be a significant improvement for things
>> like remotefilelog, which may want to request thousands of entities at
>> once.
> Is there any reason to use the non-streaming batch after this series?
> It doesn't seem to be removed in this series. Is that because there
> are still reasons to use it? Or because you're being nice to
> extensions?

Mostly sloth. A next round of patches (which I don’t *need* to have exist, but I’ll probably do anyway) would deprecate the batch() interface and replace it with a streambatch() interface, and then iterbatcher could become the only way to batch requests. I haven’t done that work yet because it’s not on my critical path.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160308/c1804989/attachment.sig>

More information about the Mercurial-devel mailing list