[PATCH 3 of 4 V2] graphmod: use different styles for different edge types

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Mar 9 09:40:04 EST 2016



On 03/04/2016 08:47 PM, Martijn Pieters wrote:
> # HG changeset patch
> # User Martijn Pieters <mjpieters at fb.com>
> # Date 1457102672 0
> #      Fri Mar 04 14:44:32 2016 +0000
> # Node ID 794d4e68aa4fcfc2da23bfd71ba1294eb82e37c3
> # Parent  ddeb44b0971f0c34b23f5f541c5d9a0b8c6c5892
> graphmod: use different styles for different edge types
>
> Rather than always draw edges as solid lines, use dotted lines for edges that
> do not connect to a parent, and dashed lines when connecting to a grandparent
> (implying missing nodes in between).
>
> This is part of the work towards moving smartlog upstream; currently smartlog
> injects extra nodes into the graph to indicate grandparent relationships (nodes
> elided).

As durham mention, that would be nice to have an exemple output in the 
description.

Can we have change for each relation types in different changeset? This 
would help discussion of each of them.

I like the ":" for grandparent, but I'm not fan of using "." for missing 
parent. I feel like we should safe "." something more common/important 
like obsolescence relation.

I like the fact we don't include the elypsis node. It allows a much more 
compact result.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list