[PATCH 1 of 4] revset: remove useless class

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Mar 9 10:44:37 EST 2016



On 03/09/2016 03:41 PM, Yuya Nishihara wrote:
> On Thu, 10 Mar 2016 00:23:52 +0900, FUJIWARA Katsunori wrote:
>> At Wed, 9 Mar 2016 14:50:51 +0000,
>> Pierre-Yves David wrote:
>>> On 03/09/2016 02:29 PM, FUJIWARA Katsunori wrote:
>>>> # HG changeset patch
>>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>>> # Date 1457533235 -32400
>>>> #      Wed Mar 09 23:20:35 2016 +0900
>>>> # Node ID 3d5ebabcfa15563df46646edf05f8d1da2343a2b
>>>> # Parent  f126bb86a4e282fc1113a9c67777e9ca3764e57b
>>>> revset: remove useless class
>>>>
>>>> Previous patch makes this classes useless by replacing it with
>>>> registrar.revsetpredicate.
>>>
>>> It seems like this is going to break extension.
>>>
>>> Can we have a deprecation periode for this? (using deprecation api with
>>> devel warning?).
>>>
>>> In all cases, we probably want a (API) to this.
>>
>> OK, I'll send revised series with deprecation handling.
>
> Do we have to care for it? These classes exist only in 3.7.x, and there would
> be no third-party extension that requires 3.7. I think the (API) flag is enough.

Who knows what third party extension do? If this is cheap to keep the 
deprecated API in until 3.9 let's do it.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list