[PATCH] histedit: do not check experimental.histediting in extsetup

Sean Farley sean at farley.io
Wed Mar 9 14:11:52 EST 2016


Jun Wu <quark at fb.com> writes:

> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1457490597 0
> #      Wed Mar 09 02:29:57 2016 +0000
> # Node ID 4886a03b8b2b779cf9cf69a5dc29a2b4e8b24c52
> # Parent  ffd3ac07b1d79dda7f57bd826208fdaf92a76717
> histedit: do not check experimental.histediting in extsetup
>
> chgserver only hashes [extensions] as confighash. It expects extensions to not
> have global side effects depending on configs in {ui,ext}setup. Otherwise,
> if related configs are changed, but the [extensions] section remains same,
> a same chgserver will be reused and the extensions will still have the old
> behavior.
>
> This patch fixes the issue by moving experimental.histediting check out from
> extsetup.

Seems fine to me.


More information about the Mercurial-devel mailing list