[PATCH] histedit: do not check experimental.histediting in extsetup

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Mar 10 10:56:44 EST 2016

On 03/10/2016 03:54 PM, Jun Wu wrote:
> On 03/10/2016 03:48 PM, Pierre-Yves David wrote:
>> So what is the new way to handle the "ng" action? Do we still have a
>> global
>> state but a delayed one?
> I think the change makes the style more consistent. There are a few
> *actions
> variables scoped in the histedit module, which looks okay to me. I just
> added
> another one.
> The state (hiddenactions) is re-calculated per histedit command so it
> will be
> always up-to-date.

But it is still in a global variable. If this is recomputed on the fly, 
can't we keep it in the scope of the function?


Pierre-Yves David

More information about the Mercurial-devel mailing list