[PATCH] histedit: do not check experimental.histediting in extsetup

Jun Wu quark at fb.com
Thu Mar 10 11:23:58 EST 2016


On 03/10/2016 03:56 PM, Pierre-Yves David wrote:
> But it is still in a global variable. If this is recomputed on the fly,
> can't we keep it in the scope of the function?

It requires "ui" to compute. We don't pass "ui" down to the functions which
actually need it. I don't think passing down the "ui" object (the source of
truth) is a good idea.

If you add parameters to pass the *actions, you probably want to pass
primaryactions, secondaryactions, tertiaryactions, internalactions,
hiddenactions as well and it will be a huge change because a lot of functions
will get involved. It will also prevent other extensions from adding new
histedit actions. In general, I don't think the result will be better than the
current code.


More information about the Mercurial-devel mailing list